Conversation
Also retry in test_query_bind_dictionary
There was a problem hiding this comment.
Pull request overview
Improves query-test ordering to preserve reusable setup state and adds retry handling for dictionary-binding setup.
Changes:
- Groups only
query_setupconsumers by query. - Makes dictionary-binding tests reset and retry setup independently.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
adbc_drivers_validation/tests/conftest.py |
Refines query-test sorting. |
adbc_drivers_validation/tests/query.py |
Adds dictionary-binding setup retries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+206
to
+212
| if driver.is_retryable(e): | ||
| delay = min(60, 2 ** (attempt + 2)) | ||
| print("backing off and trying again after", delay, "seconds") | ||
| time.sleep(delay) | ||
| continue | ||
| else: | ||
| raise |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also retry in test_query_bind_dictionary