ci: bump GitHub Actions to current majors - #6
Merged
Merged
Conversation
The v2.3.0 checkmate-app release run warned that several actions still target Node 20, which runners are force-upgrading to Node 24 and will eventually stop supporting. Bumping the whole set rather than only those, so the next deprecation is not a second sweep. Also moves actions/cache off v3, whose service backend is retired.
golangci-lint has been failing on main since the suppression matcher landed, and the failure is present in the v1.5.0 tag. Four errcheck findings on deferred Close calls — one prepared statement, three test databases. Not a correctness defect: the statement is read-only within its transaction and the test databases are torn down regardless. But a red lint check on main is a check nobody reads, which is how the next real finding gets missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps all GitHub Actions to their current major versions, prompted by the Node 20 deprecation warnings on the v2.3.0 checkmate-app release run.
Also moves
actions/cacheoff v3, whose backend is retired.Includes a second, unrelated commit: golangci-lint has been failing on main since the suppression matcher landed, and that failure is present in the v1.5.0 tag. Four errcheck findings on deferred
Closecalls. Not a correctness defect — the statement is read-only within its transaction, the test databases are torn down regardless — but a red check on main is a check nobody reads.CI green: both
CIandgolangci-lint.