馃悰 (redisq) preserve unread messages and retry pending entries - #28
Open
puqiulin wants to merge 3 commits into
Open
馃悰 (redisq) preserve unread messages and retry pending entries#28puqiulin wants to merge 3 commits into
puqiulin wants to merge 3 commits into
Conversation
puqiulin
commented
Jul 30, 2026
puqiulin
commented
- continuously retry Redis Stream pending messages
- prevent poison messages from blocking new messages
- preserve entries still required by any consumer group during trimming
- add stream lag, pending, safe-boundary, and trim-count logs
- add regression tests for retry fairness and group-safe trimming
ionling
requested changes
Jul 31, 2026
| return collections.Map(xms, fromRedisMsg), nil | ||
| } | ||
| xms = xss[0].Messages | ||
| r.PendingID = r.pendingStartID |
Contributor
There was a problem hiding this comment.
This line will retry all the pending messages forever.
For some messages which cannot be consumed, retry 1 time is enough I think.
|
|
||
| for stream, maxLen := range trims { | ||
| stats, err := c.trimStreamWithStats(trimCtx, stream, maxLen) | ||
| streamLogger := logger.With( |
Contributor
There was a problem hiding this comment.
Good design. It's helpful for debugging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.