Skip to content

fix(feed): escape author and title fields in Atom feed template #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thostetler wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(feed): escape author and title fields in Atom feed template #658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions help/common/feed.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ layout: null

<title>NASA/SAO Astrophysics Data System</title>
<link href="https://ui.adsabs.harvard.edu/"/>
<link type="application/atom+xml" rel="self" href="http://adsabs.github.io/atom.xml"/>
<link type="application/atom+xml" rel="self" href="https://adsabs.github.io/atom.xml"/>
<updated>{{ site.time | date_to_xmlschema }}</updated>
<id>https://ui.adsabs.harvard.edu/</id>
<author>
Expand All @@ -15,20 +15,24 @@ layout: null
</author>
<rights>Copyright © 2015, NASA/SAO Astrophysics Data System</rights>

{% for post in site.posts limit:10 %}
{% if post.category contains 'blog' %}
{% assign blog_posts = site.posts | where: "category", "blog" %}
{% for post in blog_posts limit: 10 %}
<entry>
<id>http://adsabs.github.io{{ post.id }}</id>
<link type="text/html" rel="alternate" href="https://adsabs.github.io{{ post.url }}"/>
<title>{{ post.title }}</title>
<id>http://adsabs.github.io{{ post.id | xml_escape }}</id>
<link type="text/html" rel="alternate" href="https://adsabs.github.io{{ post.url | xml_escape }}"/>
<title>{{ post.title | xml_escape }}</title>
<published>{{ post.date | date_to_xmlschema }}</published>
<updated>{{ post.date | date_to_xmlschema }}</updated>
<author>
<name>{{ post.author }}</name>
<name>{{ post.author | xml_escape }}</name>
</author>
Comment thread
thostetler marked this conversation as resolved.
{% if post.description %}
<summary>{{ post.description | xml_escape }}</summary>
{% else %}
<summary>{{ post.content | strip_html | replace: '&amp;', '&' | replace: '&lt;', '<' | replace: '&gt;', '>' | replace: '&quot;', '"' | replace: '&#39;', "'" | truncatewords: 50 | xml_escape }}</summary>
{% endif %}
<content type="html">{{ post.content | xml_escape }}</content>
</entry>
{% endif %}
{% endfor %}

</feed>