Skip to content

fix(deps): upgrade requests to 2.33.0 (GHSA-gc5v-m9x4-r6x2 / CVE-2026-25645) - #12

Open
adrienpessu with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-insecure-temp-file-reuse
Open

fix(deps): upgrade requests to 2.33.0 (GHSA-gc5v-m9x4-r6x2 / CVE-2026-25645)#12
adrienpessu with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-insecure-temp-file-reuse

Conversation

Copilot AI commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

requests==2.32.5 is vulnerable to insecure temp file reuse in extract_zipped_paths() — a local attacker could pre-create a malicious file that gets loaded in place of a legitimate one.

Changes

  • Pipfile: tighten constraint from "*"">=2.33.0" to exclude the vulnerable range
  • Pipfile.lock: re-locked to requests==2.33.0 (minimum patched version)

Reachability

Not reachable — high confidence. The vulnerability only affects callers of requests.utils.extract_zipped_paths(), which is never called in this codebase. The sole usage of requests is requests.post() in codeqldepgraph/octokit.py. This change satisfies the Dependabot alert rather than mitigating an active risk.

Original prompt

This section details the Dependabot vulnerability alert you should resolve

<alert_title>Requests has Insecure Temp File Reuse in its extract_zipped_paths() utility function</alert_title>
<alert_description>### Impact
The requests.utils.extract_zipped_paths() utility function uses a predictable filename when extracting files from zip archives into the system temporary directory. If the target file already exists, it is reused without validation. A local attacker with write access to the temp directory could pre-create a malicious file that would be loaded in place of the legitimate one.

Affected usages

Standard usage of the Requests library is not affected by this vulnerability. Only applications that call extract_zipped_paths() directly are impacted.

Remediation

Upgrade to at least Requests 2.33.0, where the library now extracts files to a non-deterministic location.

If developers are unable to upgrade, they can set TMPDIR in their environment to a directory with restricted write access.</alert_description>

moderate
GHSA-gc5v-m9x4-r6x2, CVE-2026-25645
requests
pip
<vulnerable_versions>= 2.32.5</vulnerable_versions>
<patched_version>2.33.0</patched_version>
<manifest_path>Pipfile.lock</manifest_path>

https://github.com/psf/requests/security/advisories/GHSA-gc5v-m9x4-r6x2 https://github.com/psf/requests/commit/66d21cb07bd6255b1280291c4fafb71803cdb3b7 https://github.com/psf/requests/releases/tag/v2.33.0 https://nvd.nist.gov/vuln/detail/CVE-2026-25645 https://github.com/advisories/GHSA-gc5v-m9x4-r6x2

<task_instructions>Resolve this alert by updating the affected package to a non-vulnerable version. Prefer the lowest non-vulnerable version (see the patched_version field above) over the latest to minimize breaking changes. Include a Reachability Assessment section in the PR description. Review the alert_description field to understand which APIs, features, or configurations are affected, then search the codebase for usage of those specific items. If the vulnerable code path is reachable, explain how (which files, APIs, or call sites use the affected functionality) and note that the codebase is actively exposed to this vulnerability. If the vulnerable code path is not reachable, explain why (e.g. the affected API is never called, the vulnerable configuration is not used) and note that the update is primarily to satisfy vulnerability scanners rather than to address an active risk. If the advisory is too vague to determine reachability (e.g. 'improper input validation' with no specific API named), state that reachability could not be determined and explain why. Include a confidence level in the reachability assessment (e.g. high confidence if the advisory names a specific API and you confirmed it is or is not called, low confidence if the usage is indirect and hard to trace). If no patched version is available, check the alert_description field for a Workarounds section — the advisory may describe configuration changes or usage patterns that mitigate the vulnerability without a version update. If a workaround is available, apply it and leave a code comment referencing the advisory identifier explaining it is a temporary mitigation. If neither a patch nor a workaround is available, explain in the PR description why the alert cannot be resolved automatically so a human reviewer can take over. Inspect the repository to determine which package manager is used (e.g. lock files, config files, build scripts) and use that tooling to perform the update — do not edit lock files directly. If the version constraint in the manifest (e.g. package.json, Gemfile, pyproject.toml) caps the version below the fix, update the constraint first. For transitive dependencies, determine whether it is simpler to update the direct dependency that pulls in the vulnerable package or to update the transitive dependency directly, and choose the least disruptive approach. If upgrading to fix the vulnerability forces a major version bump or known breaking changes, review the changelog or release notes, then audit the codebase for usage of affected APIs and fix any breaking changes that are found. If the package manager fails to resolve dependencies (e.g. peer dependency conflicts, incompatible engine constraints), document the error in the PR description rather than attempting increasingly complex workarounds. After updating, check the lock file to confirm the package no longer resolves to a version in the vulnerable range. Keep changes minimal and tightly scoped. Ensure tests, build, type checking, and linting all pass after your changes. If there are any test, lint, or typechecking failures, investigate whether they are caused by the update and fix them if so — do not leave broken tests in the PR. If they were already present before the updat...

  • Resolves advanced-security/codeql-dependency-graph-action alert #18

Copilot AI changed the title [WIP] Fix insecure temp file reuse in extract_zipped_paths() fix(deps): upgrade requests to 2.33.0 (GHSA-gc5v-m9x4-r6x2 / CVE-2026-25645) Jul 2, 2026
Copilot AI requested a review from adrienpessu July 2, 2026 13:19
@adrienpessu
adrienpessu marked this pull request as ready for review July 2, 2026 13:39
@adrienpessu

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

…temp-file-reuse

# Conflicts:
#	Pipfile
#	Pipfile.lock

Copilot AI commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Resolved. Merged origin/main into this branch, kept requests = ">=2.33.0" while restoring the urllib3 = "*" entry that was added by the urllib3 fix PR. Regenerated Pipfile.lock — now resolves to requests==2.34.2 and urllib3==2.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants