fix: 🐛 use pagehide for lifecycle cleanup#57
Open
aermin wants to merge 1 commit into
Open
Conversation
aermin
force-pushed
the
agent/fix-pagehide-lifecycle
branch
3 times, most recently
from
July 22, 2026 14:55
0a1c109 to
6abe81d
Compare
aermin
force-pushed
the
agent/fix-pagehide-lifecycle
branch
from
July 22, 2026 15:17
6abe81d to
27bc1bb
Compare
aermin
marked this pull request as ready for review
July 22, 2026 15:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #56 by replacing lifecycle cleanup that relied on the deprecated
unloadevent withpagehide.Why
Registering
unloadhandlers can trigger Chrome permissions policy warnings. Unlikeunload,pagehidealso reports whether a page is entering the back-forward cache throughevent.persisted.Changes
unloadhandlers for heartbeat and lock cleanup.pagehide.pagehide.persisted === true.test/bfcache.test.tsfor both lifecycle branches.The tests exercise this polyfill's lifecycle handling; existing cross-context heartbeat behavior is unchanged.
Validation
npm test -- --runInBand(13 suites, 68 tests)npm run lintnpm run build