Migrate TieredInt wire sizes to pinned ae-numeric - #540
Merged
Conversation
Replace legacy numeric TieredInt with ae::PackedSize/PacketSize backed by ae-numeric@b82a367, keep packet/message framing byte-identical, and cover golden plus fragmented header cases in Aether tests. Co-authored-by: Cursor <cursoragent@cursor.com>
aether-tele@4aa5666 already uses ae-numeric, so remove the temporary PATCHES workaround and pin that commit instead of floating main.
Co-authored-by: Cursor <cursoragent@cursor.com>
BartolomeyKant
requested changes
Aug 25, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
BartolomeyKant
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TieredIntto pinnedae-numeric(68fcbb3) with targetae-numeric.PackedSize = TieredInt<uint8_t, 250, 1514, 1049834>(PacketSizealias).wire_traits/Serialize/Deserialize/WireBytesNeededAPI.sizeof(ValueType)overhead uses withkMaxWireBytes.origin/main(aether.lib−15 154,ab-message-exchange.exe−1 024).aether-teleat7424eb5and remove the temporaryaether-tele-ae-numeric.patch(tele migration: aether-tele PR #5).Test plan
test-transport(includes golden + fragmented header tests) passed in CI matrixnumeric/tiered_int.h,TierDeserializeRes, old 3-paramTieredInt, or tele patchtext_io/ostream_ioincludesesp_wifi_driver.cppcan fail onESP_LOGI(... "%d", int32_t)under-Werror=format. That is unrelated to the numeric migration and was not changed here. CI ESP-IDF latest is green.