feat(server): expand controls list with attachments#228
Draft
abhinav-galileo wants to merge 1 commit into
Draft
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
include_attachmentsexpansion onGET /api/v1/controlsUsage
List controls without attachment expansion, preserving the existing lightweight response:
List controls with direct agents, policies, and target bindings expanded for each returned control:
Optionally filter expanded target bindings by opaque target type:
Each expanded control includes:
{ "attachments": { "agents": [{ "agent_name": "example-agent" }], "policies": [{ "policy_id": 42 }], "targets": [ { "binding_id": 123, "target_type": "environment", "target_id": "prod", "enabled": true } ] } }For full target-binding pagination/filtering, callers can continue using
GET /api/v1/control-bindings.Validation
uv run pytest server/tests/test_controls_additional.py::test_list_controls_returns_null_attachments_by_default server/tests/test_controls_additional.py::test_list_controls_expands_policy_agent_and_target_attachments -quv run pytest server/tests/test_controls_additional.py server/tests/test_control_bindings_endpoints.py server/tests/test_services_controls.py -qmake openapi-spec-checkmake sdk-ts-typecheckmake sdk-ts-lintmake prepushmake server-testmake sdk-ts-generate-check