fix(approval): ask about the command, not the paperwork around it - #26
Merged
Conversation
The approval box is the one screen where a misleading line has a cost, and
it was showing the whole argument object — with the command it is asking
about crowded off the end:
╭──────────────────────────────────────────────────────────────────────╮
│ bash command │
│ command: echo escalated, description: an escalating echo, sandbox_… │
│ the gallery needs the approval box │
│ ⚠ escalate sandbox to danger-full-access: the gallery needs the … │
The escalation fields are already the warning row's job, stated right
below with their justification, so the command line repeated them and then
truncated mid-word. Now it carries the salient argument — the same
projection the `⏺ Tool(args)` row uses, which for a shell call is exactly
the command:
╭──────────────────────────────────────────────────────────────────────╮
│ Bash command │
│ echo escalated │
│ ⚠ escalate sandbox to danger-full-access: the gallery needs the … │
│ Do you want to proceed? │
│ ❯ 1. Yes │
│ 2. No │
The header takes the display label too — `Bash command`, not `bash
command` — the same `toolTrailLabel` the trail already applies to the wire
name everywhere else.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The approval box is the one screen where a misleading line has a cost, and it was showing the whole argument object — with the command it is asking about crowded off the end.
Why
The escalation fields are already the warning row's job — stated right below, with their justification — so the command line repeated them and then truncated mid-word. It now carries the salient argument: the same projection the
⏺ Tool(args)row uses, which for a shell call is exactly the command, untruncated (the 64-column cap belongs to the trail row, not here).The header takes the display label too —
Bash command, notbash command— via the sametoolTrailLabelthe trail already applies to the wire name everywhere else.Test
npm run typecheck,npm test— 150 files / 1953 passingnode scripts/verify-boundary.mjsharnessClient.test.ts: an escalating bash call's approval carriesecho escalatedbash_escalategallery scenario (--live 12)🤖 Generated with Claude Code