hack: Move development scripts - #629
Merged
timflannagan merged 1 commit intoAug 21, 2026
Merged
Conversation
Keep repository development tooling under hack while reserving scripts for the public arctl installer. Update build and documentation references to the new locations without changing script behavior. Signed-off-by: timflannagan <timflannagan@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Moves local development and Helm chart testing scripts from scripts/ to hack/, updating Makefile targets and documentation to reference the new locations while keeping the public scripts/get-arctl installer under scripts/.
Changes:
- Updated Makefile targets to invoke Kind and helm-unittest scripts from
hack/. - Added the relocated Kind setup scripts/config and helm-unittest installer under
hack/. - Updated documentation references from
scripts/kind/...tohack/kind/....
Reviewed changes
Copilot reviewed 3 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Makefile | Updates script invocations to point to hack/ paths for Kind setup and helm-unittest installation. |
| hack/kind/setup-metallb.sh | Relocated MetalLB install/config script for local Kind clusters. |
| hack/kind/setup-kind.sh | Relocated Kind cluster creation script (incl. optional local registry wiring). |
| hack/kind/README.md | Relocated Kind dev-environment documentation under hack/. |
| hack/kind/kind-config.yaml | Relocated Kind cluster configuration YAML. |
| hack/install-helm-unittest.sh | Relocated helm-unittest plugin installer used by Makefile chart tests. |
| docs/governance/cncf/technical-review.md | Updates Kind documentation reference to the new hack/kind/README.md path. |
| DEVELOPMENT.md | Updates Kind documentation link to the new hack/kind/README.md path. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lcopi
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move repository development tooling for Kind and Helm chart tests from
scripts/tohack/. Keep the publicget-arctlinstaller underscripts/and update all Makefile and documentation references to the new paths.
This is an exact relocation with no script behavior changes.
Change Type
/kind cleanup
Changelog
Additional Notes
Validated shell syntax, executable modes, exact file contents, path references,
Makefile command expansion, and
git diff --check. Broad test and lint targetswere not run because this is a path-only maintenance change.