fix(security): restrict tokenless dev mode to loopback (#408)#418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands @danyalahmed1995's security hardening from #408, rebased onto current
mainto resolve conflicts indocs/quickstart.md(which was rewritten in #417). No behavior changes from the original PR — same code, docs, and tests.What
Tokenless
CMCP_DEV_MODE=1now binds to loopback only. Reaching the gateway from a LAN, container, or cloud network requiresCMCP_BEARER_TOKEN, so an unauthenticated gateway can't be exposed by accident. Adds a properparse_listen_addr(handles IPv6 bracket form) and a loopback check, with unit tests.Full suite green after rebase: 833 passed, 6 skipped. Original CI on #408 was all green.
Credit: @danyalahmed1995 (commit authorship preserved). Supersedes #408.
Co-Authored-By: Danyal Ahmed 58849388+danyalahmed1995@users.noreply.github.com
🤖 Generated with Claude Code