Require kompo-vfs 0.7.0 - #67
Merged
Merged
Conversation
WalkthroughThe project raises its minimum supported ChangesKompo VFS Version Update
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ahogappa
force-pushed
the
claude/kompo-gem-path-generation-3okpzr
branch
from
August 1, 2026 02:05
4a8c0fe to
04192f1
Compare
KOMPO_VFS_MIN_VERSION is not only a floor: kompo_vfs_path.rb builds the release tarball URL and the install directory name from it, and CI checks out the same tag to build from source. So bumping it moves all three at once, and every place that pinned 0.6.0 has to move together. - lib/kompo/version.rb: the constant - .github/workflows/ci.yml: the tag checked out before cargo build - test/tasks/kompo_vfs_path_test.rb: fixtures feeding verify!, which would now raise on a 0.6.0 KOMPO_VFS_VERSION file The too-old case now uses 0.6.0 rather than 0.5.1, so it pins that the bar actually moved - it fails against the previous constant. The remaining 0.6.0 literals are deliberate: get_version tests whitespace stripping and version_satisfies? tests comparison, neither of which reads the constant. The cargo target cache key in ci.yml is left alone. Its "-v6-" marker does not track the kompo-vfs version in the file's history, and editing ci.yml already invalidates the key through hashFiles. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ahogappa
force-pushed
the
claude/kompo-gem-path-generation-3okpzr
branch
from
August 1, 2026 02:09
04192f1 to
b25781e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the required kompo-vfs version from 0.6.0 to 0.7.0.
Why this touches four places
KOMPO_VFS_MIN_VERSIONis not only a floor.kompo_vfs_path.rbbuilds the release tarball URL and the install directory name from it, and CI checks out the same tag to build from source. Bumping it moves all three behaviours at once, so every site that pinned 0.6.0 has to move together.lib/kompo/version.rbKOMPO_VFS_MIN_VERSION→0.7.0.github/workflows/ci.ymlcargo build --release→v0.7.0test/tasks/kompo_vfs_path_test.rbverify!, which now raises on a0.6.0KOMPO_VFS_VERSIONfileCHANGELOG.mdGenerated by Claude Code
Summary by CodeRabbit
Compatibility
Documentation