Skip to content

fix: reject overlapping portal lines during creation - #4

Merged
ai-eks merged 1 commit into
mainfrom
fix/prevent-overlapping-portal-lines
Jul 24, 2026
Merged

fix: reject overlapping portal lines during creation#4
ai-eks merged 1 commit into
mainfrom
fix/prevent-overlapping-portal-lines

Conversation

@ai-eks

@ai-eks ai-eks commented Jul 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • reject a portal pair when both lines overlap or share an endpoint on the same display edge
  • keep the editor on the second-line step and show a localized red validation message
  • add coverage for overlap, endpoint touching, separated lines, and final build validation
  • bump the app version to 1.0.1 (build 2)

Why

A portal could previously be created with both endpoints occupying the same edge range. In edge cases this can cause ambiguous bidirectional cursor warping. Validation now happens while creating the second line and again before building the portal.

User impact

Invalid second lines are not saved. The editor explains the problem and lets the user redraw the second line immediately.

Validation

  • swift test — 112 tests passed
  • git diff --check

@ai-eks
ai-eks merged commit d84e70d into main Jul 24, 2026
1 check passed
@ai-eks
ai-eks deleted the fix/prevent-overlapping-portal-lines branch July 24, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant