Support item access to DockerVolume - #1044
Open
james-emerton wants to merge 5 commits into
Open
Conversation
Implement kwargs and `__getitem__()` as per `DockerContainer`
for more information, see https://pre-commit.ci
Restore support for `DockerVolume(docker, name)`
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1044 +/- ##
==========================================
+ Coverage 75.11% 75.13% +0.02%
==========================================
Files 26 26
Lines 1965 1971 +6
Branches 272 272
==========================================
+ Hits 1476 1481 +5
- Misses 406 407 +1
Partials 83 83 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
The attribute access support in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement kwargs and
__getitem__()as perDockerContainerWhat do these changes do?
This allows the user to access properties of a volume directly from the
DockerVolumeinstance.Are there changes in behavior for the user?
Arguments to
DockerVolumeconstructor have changed. I have added support for a positionalnameargument.Checklist
CONTRIBUTORS.txtchangesfolder<issue_id>.<type>for example (588.bug)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.