Clarify timeout behavior in containers.delete comment - #1045
Open
mdegat01 wants to merge 1 commit into
Open
Conversation
Changed comment to clarify the default timeout behavior for delete operations.
Contributor
Author
|
This seems too trivial for a changelog entry but if you want one let me know and I'll add it |
14 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1045 +/- ##
=======================================
Coverage 75.11% 75.11%
=======================================
Files 26 26
Lines 1965 1965
Branches 272 272
=======================================
Hits 1476 1476
Misses 406 406
Partials 83 83 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
When trying to figure out the default timeout behavior for various methods I noticed this comment in
containers.deletedidn't match what was actually happening. I assumed the comment was wrong so figured I'd just put up a tiny PR to fix it.Are there changes in behavior for the user?
None
Related issue number
Checklist
CONTRIBUTORS.txtchangesfolder<issue_id>.<type>for example (588.bug)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.