Make extension views in postgres be recognised as system views#382
Open
jonknight73 wants to merge 2 commits into
Open
Make extension views in postgres be recognised as system views#382jonknight73 wants to merge 2 commits into
jonknight73 wants to merge 2 commits into
Conversation
|
jsimlo
requested changes
Jul 17, 2026
| protected boolean isSystemTable(RealName tableName) { | ||
| return extensionRelationNames.get().contains(tableName); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Calling super as well would be good pracitise :)
| @Override | ||
| protected boolean isSystemView(RealName viewName) { | ||
| return extensionRelationNames.get().contains(viewName); | ||
| } |
Contributor
There was a problem hiding this comment.
So there was something about "SystemView" before, that is good :)
Again, or super.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make Extension views be recognised as system views so they are excluded from upgrade path calculations.