Skip to content

Fix pagination loop termination with since filter#10

Open
911-Studio wants to merge 1 commit into
alisteuber4ee1:mainfrom
911-Studio:fix-pagination-since
Open

Fix pagination loop termination with since filter#10
911-Studio wants to merge 1 commit into
alisteuber4ee1:mainfrom
911-Studio:fix-pagination-since

Conversation

@911-Studio

Copy link
Copy Markdown

Changes

  • Use Issues.ListByRepo for repository issue fetching.
  • Continue pagination using resp.NextPage.
  • Preserve the Since filter across paginated requests.
  • Skip duplicate issues by GitHub issue ID.
  • Add test coverage for:
    • multiple paginated requests
    • since present on every request
    • short pages
    • empty page with next link
    • duplicate issue IDs

Verification

  • go test ./...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants