Skip to content

feat: add comprehensive ROS local validation#180

Merged
guima-why merged 1 commit into
mainfrom
op-ros-validate-function
Jul 24, 2026
Merged

feat: add comprehensive ROS local validation#180
guima-why merged 1 commit into
mainfrom
op-ros-validate-function

Conversation

@guima-why

@guima-why guima-why commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • add local semantic validation for all 43 supported ROS functions
  • infer and validate Ref, Fn::GetAtt, Resource, DataSource, extension resources, and Count behavior
  • report all independent diagnostics with line, column, path, summary, and poisoned-cascade suppression
  • run validation before ROS API requests, blocking on errors and attaching warnings to ToolResult
  • preserve public invocation binding, one-shot authorization snapshots, and authorized TemplateBody materialization
  • add complete ROS validation translations for zh, es, fr, de, ja, and pt
  • add curated ROS validation catalogs, official-evidence refresh tooling, and focused validator, hook, adapter, permission, and i18n regression tests

Why

ROS templates could previously pass local generation even when intrinsic-function argument types or substitution semantics were invalid. Some failures surfaced only during PreviewStack, while others were not exposed consistently. This adds stronger local feedback without replacing ValidateTemplate.

User impact

Invalid templates fail earlier with actionable diagnostics. Warnings remain attached to the normal tool result, and valid requests continue through the existing permissions, credentials, endpoint, and ROS API flow.

Validation

  • make translate
  • make lint
  • targeted ROS validator, hook, API adapter, permission, ToolExecutor, and i18n tests
  • make test: 11358 passed, 2 skipped
  • git diff --check

@guima-why
guima-why force-pushed the op-ros-validate-function branch from f5543a3 to 1635934 Compare July 24, 2026 13:04
@guima-why
guima-why marked this pull request as ready for review July 24, 2026 14:11
@guima-why
guima-why merged commit 31bb307 into main Jul 24, 2026
13 checks passed
@guima-why
guima-why deleted the op-ros-validate-function branch July 24, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant