feat: add comprehensive ROS local validation#180
Merged
Conversation
guima-why
force-pushed
the
op-ros-validate-function
branch
from
July 24, 2026 13:04
f5543a3 to
1635934
Compare
guima-why
marked this pull request as ready for review
July 24, 2026 14:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
ROS templates could previously pass local generation even when intrinsic-function argument types or substitution semantics were invalid. Some failures surfaced only during PreviewStack, while others were not exposed consistently. This adds stronger local feedback without replacing ValidateTemplate.
User impact
Invalid templates fail earlier with actionable diagnostics. Warnings remain attached to the normal tool result, and valid requests continue through the existing permissions, credentials, endpoint, and ROS API flow.
Validation
make translatemake lintmake test: 11358 passed, 2 skippedgit diff --check