Skip to content

shard: skip hashmapStats allocation when stats are disabled #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
c-tonneslan wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −10
Open

shard: skip hashmapStats allocation when stats are disabled #423

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30c655f
shard: skip hashmapStats allocation when stats are disabled
c-tonneslan May 31, 2026
2a0c75d
Merge branch 'main' into fix/skip-hashmapstats-alloc-when-stats-disabled
janisz Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions shard.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,16 +437,11 @@ func initNewShard(config Config, callback onRemoveCallback, clock clock) *cacheS
if maximumShardSizeInBytes > 0 && bytesQueueInitialCapacity > maximumShardSizeInBytes {
bytesQueueInitialCapacity = maximumShardSizeInBytes
}
var hashmapStatsCapacity int
if config.StatsEnabled {
hashmapStatsCapacity = config.initialShardSize()
}
return &cacheShard{
hashmap: make(map[uint64]uint64, config.initialShardSize()),
hashmapStats: make(map[uint64]uint32, hashmapStatsCapacity),
entries: *queue.NewBytesQueue(bytesQueueInitialCapacity, maximumShardSizeInBytes, config.Verbose),
entryBuffer: make([]byte, config.MaxEntrySize+headersSizeInBytes),
onRemove: callback,
shard := &cacheShard{
hashmap: make(map[uint64]uint64, config.initialShardSize()),
entries: *queue.NewBytesQueue(bytesQueueInitialCapacity, maximumShardSizeInBytes, config.Verbose),
entryBuffer: make([]byte, config.MaxEntrySize+headersSizeInBytes),
onRemove: callback,

isVerbose: config.Verbose,
logger: newLogger(config.Logger),
Expand All @@ -455,4 +450,8 @@ func initNewShard(config Config, callback onRemoveCallback, clock clock) *cacheS
statsEnabled: config.StatsEnabled,
cleanEnabled: config.CleanWindow > 0,
}
if config.StatsEnabled {
shard.hashmapStats = make(map[uint64]uint32, config.initialShardSize())
}
return shard
}
Loading