Group notebook summaries and transcripts under parent SummaryGroup (#233) - #238
Open
allenporter wants to merge 1 commit into
Open
Group notebook summaries and transcripts under parent SummaryGroup (#233)#238allenporter wants to merge 1 commit into
allenporter wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #233.
In the Supernote ecosystem and Partner App, digests belonging to the same notebook/document are grouped under a parent
SummaryGroup(is_summary_group="Y"/True). Previously,SummaryModuleproduced root-level summaries (parent_unique_identifier=None) for raw OCR transcripts and Gemini summaries, leading to an unorganized flat digest list in the app.Changes
get_summary_group_id(file_basis: str) -> strinsupernote.server.utils.pathsreturning{file_basis}-group._upsert_groupinSummaryModuleto ensure aSummaryGroupexists for each note before adding/updating summaries.{file_basis}-transcript) and AI summary ({file_basis}-summary) to the parent group by settingparent_unique_identifier.SummaryService.update_summaryto support updatingparent_unique_identifier,source_path, anddata_sourcewhen provided inUpdateSummaryDTO.tests/server/utils/test_paths.pyfor full 1:1 test parity.test_summary.pyto verify group creation/updates andparent_unique_identifierpropagation.test_processor_integration.pyto assert database group creation and child summary hierarchy.Verification