fix: don't retry a failed provider / anthropic bug - #47
Merged
Conversation
…ng models Two independent fallback bugs surfaced by a cross-provider agent run where Anthropic 400d and every turn silently fell back to Gemini. 1. Tool input wrapping. A wrapper-object tool (non-object top-level schema) stores only its inner value. When that call is replayed after the tool is no longer registered, nothing re-wraps it, so the raw scalar reached Anthropic as tool_use.input and was rejected with "Input should be an object". Add a shared ensureToolInputObject that wraps stray non-objects under `content`, and route both the Anthropic history serializer and the shared serializeWrappedToolArguments (which had the same unregistered-tool gap) through the guarantee. Not adapter-specific. 2. Fallback latency. A deterministic input-level error (4xx client, unsupported_file_type, image_too_large) recurs on every later turn because history only grows, yet each turn restarted the fallback list at the primary and re-paid the guaranteed failure. Track such models per run and skip them as long as a viable fallback remains. Assisted-by: claude-opus-4.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent fallback bugs surfaced by a cross-provider agent run where Anthropic 400d and every turn silently fell back to Gemini.
Tool input wrapping. A wrapper-object tool (non-object top-level schema) stores only its inner value. When that call is replayed after the tool is no longer registered, nothing re-wraps it, so the raw scalar reached Anthropic as tool_use.input and was rejected with "Input should be an object". Add a shared ensureToolInputObject that wraps stray non-objects under
content, and route both the Anthropic history serializer and the shared serializeWrappedToolArguments (which had the same unregistered-tool gap) through the guarantee. Not adapter-specific.Fallback latency. A deterministic input-level error (4xx client, unsupported_file_type, image_too_large) recurs on every later turn because history only grows, yet each turn restarted the fallback list at the primary and re-paid the guaranteed failure. Track such models per run and skip them as long as a viable fallback remains.
Assisted-by: claude-opus-4.8