dependency day 18th august - #448
Merged
Merged
Conversation
rparke
force-pushed
the
rp-dependency-day-18th-august
branch
from
August 18, 2026 15:47
65efd43 to
dde504b
Compare
note: werkzeug 3.1.7 now sets the `Accept-Ranges` header when before it didn't. AFAIK we don't use this headever value anyway because we don't download by selecting specific byte ranges
rparke
force-pushed
the
rp-dependency-day-18th-august
branch
from
August 18, 2026 15:58
dde504b to
dd05b16
Compare
rparke
commented
Aug 18, 2026
Comment on lines
43
to
45
| assert dict(response.headers) == { | ||
| "Accept-Ranges": mock.ANY, | ||
| "Cache-Control": mock.ANY, |
Contributor
Author
There was a problem hiding this comment.
We could be explicit and add "Accept-Ranges": bytes because the spec doesn't ACTUALLY allow any other options but again ... this header in the response isn't used because we just download the file in one go.
quis
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.