Convert key:value tables to summary lists - part 2 - #6046
Open
kr8n3r wants to merge 11 commits into
Open
Conversation
kr8n3r
force-pushed
the
convert-tables-to-lists-part-2
branch
2 times, most recently
from
August 26, 2026 14:22
6c55293 to
da828c0
Compare
kr8n3r
added a commit
to alphagov/notifications-functional-tests
that referenced
this pull request
Aug 27, 2026
Needed for alphagov/notifications-admin#6046 We look both both current and future selectors, like we did in #665, so tests can be merged before admin. Once admin is merged, we'll do a cleanup here.
kr8n3r
force-pushed
the
convert-tables-to-lists-part-2
branch
2 times, most recently
from
August 27, 2026 14:30
44a6c6a to
74b4d2b
Compare
Update table to summary list Utilises classes created in #6029
Create a simplified version of the notification_status_field macro from the table component to be used in the notifications lists. Styles for it were taken from components/table.scss and rewritten. Once we've migrated all the tables to either summary-lists or govuk-frontend tables, the table macros can safely be deleted. Note: Ideally this would be called `notification-status` but we already use that some something else, so did not want to create more changes.
Update table to summary list Utilises classes created in #6029 Utilises the newly created `notification-state` component.
Update table to summary list Utilises classes created in #6029 Utilises the newly created `notification-state` component.
Stopped being used in 4fe3bbf
Update table to summary list Utilises classes created in #6029
Update target selectors
Update target For the test_sending_status_hint_displays_correctly_on_notifications_page which was testing whether the link to the status page is present, parameters were reversed and single_line changed to has_link. This is easier to follow now that the `.notification-state` elements contains/not contains the link. Link was previously outside of the of a similar container.
Update target selectors Remove assert "Recipient" in content["notifications"] assert "Status" in content["notifications"] which were previously table headers. With the conversion to a list, this is no longer present.
Update target selectors
kr8n3r
force-pushed
the
convert-tables-to-lists-part-2
branch
from
August 27, 2026 14:44
74b4d2b to
145dc2c
Compare
kr8n3r
changed the title
kr8n3r
marked this pull request as ready for review
August 28, 2026 15:11
For utility classes that aren't part of a component. Migrate existing `.no-data` from app.scss Add `.more-items-available-text` class - modified version from `components/table.scss` for when lists and tables have more data thna we show. As this paragraph in no longer a paer of the table it doesn't make sense to have it there anymore. Once all tables have been migrated, we'll be able to safely delete table.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Convert tables on below urls to summary lists. These lists are key:value pairs so from an accessibility standpoint, a summary list that's built on description list element is more appropriate.
Continuation of the work started in #6029
Accompanying FTs alphagov/notifications-functional-tests#672 should be merged before this
Review
See individual commits for details
URLs
/services/uuid:service_id/notifications
/services/uuid:service_id/uploads
/services/uuid:service_id/jobs
/services/uuid:service_id/jobs/uuid:job_id
/services/uuid:service_id/uploaded-letters/YYY-MM-DD (when uploading a letter via /uploads)
/services/uuid:service_id/send/uuid:template_id/from-contact-list (send by uploading csv)
Visuals