log every persist notification call for SMS notifications if a user t… - #4945
Open
rparke wants to merge 2 commits into
Open
log every persist notification call for SMS notifications if a user t…#4945rparke wants to merge 2 commits into
rparke wants to merge 2 commits into
Conversation
rparke
commented
Aug 27, 2026
Comment on lines
+180
to
+191
| try: | ||
| number = PhoneNumber(strip_and_remove_obscure_whitespace(notification.to)) | ||
| five_digit_prefix = str(number.number.national_number)[:5] | ||
| if number.is_uk_mobile_number() and number.get_carrier_info == "": | ||
| current_app.logger.info( | ||
| "Service %s tried to send to UK mobile number in reserved range. Prefix without leading zero: %s", | ||
| service.id, | ||
| five_digit_prefix, | ||
| extra={"service_id": service.id, "five_digit_prefix": five_digit_prefix}, | ||
| ) | ||
| except InvalidPhoneError: | ||
| current_app.logger.info("Could not parse number") |
Contributor
Author
There was a problem hiding this comment.
The try-except is mainly just extra caution. Nothing in the logging code should stop us creating the row as normal.
rparke
commented
Aug 27, 2026
|
|
||
| # if simulated create a Notification model to return but do not persist the Notification to the dB | ||
| if not simulated: | ||
| dao_create_notification(notification=notification, _autocommit=_autocommit) |
Contributor
Author
There was a problem hiding this comment.
We could optionally get the notification_id returned to us from dao_create_notification and put that in the log message (removes the need for storing the prefix but does require some more manual effort cross referencing)
rparke
force-pushed
the
rp-add-carrier-code-check-to-phonenumber-validation
branch
from
September 1, 2026 13:13
b5ab85a to
debc30d
Compare
…ries to send to a uk mobile number in the reserved range
rparke
force-pushed
the
rp-add-carrier-code-check-to-phonenumber-validation
branch
from
September 1, 2026 13:13
debc30d to
0f7b336
Compare
rparke
marked this pull request as ready for review
September 1, 2026 13:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ries to send to a uk mobile number in the reserved range