inbound sms: remove old ad-hoc basic auth code, activate enforcement by new decorator - #4951
Open
risicle wants to merge 1 commit into
Open
inbound sms: remove old ad-hoc basic auth code, activate enforcement by new decorator#4951risicle wants to merge 1 commit into
risicle wants to merge 1 commit into
Conversation
…by new decorator this includes removal of old-style config variables used by old code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/94Q38sgQ/1546-implement-authentication-for-delivery-receipt-callback-endpoints
This includes removal of old-style config variables used by old code.
We can be quite sure this will work because neither staging or prod are currently emitting any error messages from the decorator in
log_onlymode.After this, the only thing left for this story is tidying up of old variables/credentials etc.