Send a new email to users with manage settings when a service goes live - #4953
Open
klssmith wants to merge 3 commits into
Open
Send a new email to users with manage settings when a service goes live#4953klssmith wants to merge 3 commits into
klssmith wants to merge 3 commits into
Conversation
We had an existing function for getting users for a service, but are going to have emails that get sent specifically to users with the manage settings permission for a service.
This function retrieved the active users for a service, but we will want to use it to send to two different groups of users. This changes the function so that it takes a user list as an argument. As well as fixing the tests which needed adjusting due to the change, this also simplifies a few tests by updating them so they make use of the `admin_request` fixture.
In addition to the existing email, which gets sent to all team members, we want to send a second email to team members who have the manage settings permission for the service.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently send an email to all team members of a service when the service is made live. We we now want to send two emails - one to all team members, and one to team members with the manage settings permission.
The new template, for users with the manage settings permission, has already been created in all environments.
The existing template that is currently sent to all users will have its content modified to remove the content about out of hours emergencies and admin user responsibilities. We will deploy this change, then immediately change the content of the current email. It won't be an issue if people receive the existing email with its current content before we've had a chance to change it - they will just see a tiny bit of duplication of content in both emails they receive.
Trello card