Skip to content

Environment variable replacement#21

Open
dylanmcreynolds wants to merge 2 commits intomainfrom
env_vars
Open

Environment variable replacement#21
dylanmcreynolds wants to merge 2 commits intomainfrom
env_vars

Conversation

@dylanmcreynolds
Copy link
Copy Markdown
Collaborator

Adds the ability to add environment variable replacement to the config.yaml files for blocks.

Copy link
Copy Markdown
Contributor

@xiaoyachong xiaoyachong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Dylan,
Thanks for your PR—it looks good. It would be great if you could also provide a .env.example file and update the README to include the environment variable settings.

class: myapp.operators.MessageProcessor
kwargs:
# Use env var with default fallback
timeout: ${MESSAGE_TIMEOUT:-60}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a .env.example file that includes all the environment variables defined in this YAML?

Comment thread pixi.lock
name: arroyopy
version: 0.3.0a7
sha256: 76dc3179c409495f9e06776fc63c6c8572405029c82a82b1368b9ce9282c9500
version: 0.3.0a8
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub indicates that there is a conflict when merging this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants