fix: skip npm dev install - #58
Merged
Merged
Conversation
Updated test cases to include '--omit=dev' parameter in runNpmInstall calls.
dominic-farquharson
approved these changes
Aug 3, 2026
Matthew-Mallimo
approved these changes
Aug 3, 2026
guym4c
approved these changes
Aug 3, 2026
oneamexbot
added a commit
that referenced
this pull request
Aug 4, 2026
## [1.12.3](v1.12.2...v1.12.3) (2026-08-04) ### Bug Fixes * skip npm dev install ([#58](#58)) ([5fe5728](5fe5728))
Contributor
|
🎉 This PR is included in version 1.12.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
create-using-template'sinstall-template.jsrunsnpm install <template> --savefrominside its own package directory (
__dirname). npm findscreate-using-template/package.jsonas the project root and resolves the full dependency tree — including devDependencies.
The chain
semantic-release@^25→@semantic-release/npm→npm@>=10resolves tonpm@11.19.0, which Artifactory blocks with 403 (not yet approved). This breaks every timea new npm version is published.
Fix
Add
--omit=devto the install args insrc/utils/install-template.js:Why it won't break
installTemplatestep only needs the template to berequire()-ablejs-yaml,uuid,wordlist-english,node-fetch) are still installedcreate-using-template's production deps (cross-spawn,prompts,ejs, etc.) are still installedsemantic-release,commitlint,eslint,jest) are neverrequire()d during generationTesting
git clone https://github.com/ddwivedi551/create-using-template.git cd create-using-template npm pack npx --package ./create-using-template-1.12.3.tgz create-using-template @americanexpress/one-app-v7-module-template@latest