Skip to content

Fix bold and italic button placements for text view#58

Open
rosierjolie wants to merge 1 commit into
masterfrom
fix/No-ticket-bold-italic-text-view-placements
Open

Fix bold and italic button placements for text view#58
rosierjolie wants to merge 1 commit into
masterfrom
fix/No-ticket-bold-italic-text-view-placements

Conversation

@rosierjolie
Copy link
Copy Markdown
Collaborator

@rosierjolie rosierjolie commented Apr 17, 2026

Summary

  • Fix bold and italic button placements for text view across editor view controllers (Consequence, Decision, Markdown, Metadata, and Rule editors)

Screenshots

Test plan

  • Open an existing game in the editor
  • Verify bold and italic buttons appear in the correct positions in the Markdown editor
  • Verify bold and italic buttons appear correctly in Consequence, Decision, Metadata, and Rule editors

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@rosierjolie rosierjolie requested a review from amiantos April 17, 2026 23:58
@amiantos
Copy link
Copy Markdown
Owner

We discussed moving the complete button up into the navigation bar, like in the notes app, didn't we?

Simulator Screenshot - iPhone 17 Pro - 2026-04-20 at 13 53 08

Another option could be this hovering bar like Safari does in web forms, but that's a lot less ideal than the Notes context-sensitive button in the top right.

Screenshot 2026-04-20 at 1 54 35 PM Base64 Decode and Encode - Online

@rosierjolie
Copy link
Copy Markdown
Collaborator Author

@amiantos If we want to have the editor accept changes as final with checkmark and back button cancels the changes, then we can move it to the navigation bar.

@amiantos
Copy link
Copy Markdown
Owner

@amiantos If we want to have the editor accept changes as final with checkmark and back button cancels the changes, then we can move it to the navigation bar.

In Notes.app the checkmark just closes the keyboard, it's not necessarily a save button, it just collapses the keyboard so you can see the full note content. I'd think we can do that here, too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants