Add Google API keys in AG001 - #14
Conversation
|
Thanks for this — Google API keys are a real gap in AG001's pattern set. One thing needed before it can merge: a true-negative corpus case. A new secret pattern is untested surface until something proves it doesn't over-match. Every pattern in AG001 has cost us false positives at some point — the Please add to
Use a fabricated key — the corpus is public and GitHub secret-scans this repo. Two other things worth knowing, both from work merged after you opened this:
|
|
Alright will do, ill have an update by tomorrow hopefully. Thanks for the support |
What changed
Added detection for hard coded Google API key to the existing rules. Previous covered OpenAI, AWS, GitHub but not Google.
Threat model or motivation
Trust Boundary: Source code should never contain secrets such as Google API keys. Google API keys follow a fixed format that is easy to regex and should have a low false positive rate. Test have been added to detect false postives.
Validation
make checkpassesRelated issue
Closes #8