Skip to content

Sapporo2 build system integration#1262

Open
LourensVeen wants to merge 6 commits into
amusecode:mainfrom
LourensVeen:sapporo2_build_system_integration
Open

Sapporo2 build system integration#1262
LourensVeen wants to merge 6 commits into
amusecode:mainfrom
LourensVeen:sapporo2_build_system_integration

Conversation

@LourensVeen
Copy link
Copy Markdown
Member

This adds Sapporo2 to the build system. We should merge treecode/sapporo2#16 first, and then this needs to be updated with the version hash of the new commit created by that merge.

Note that there's a commit in here that fixes the autoconf name for sapporo_light. That's unrelated and it makes absolutely no difference to anything functionally, but I discovered this copy-pasted error and decided to fix it anyway for hair splitting purposes.

Partially addresses #1209

@HannoSpreeuw HannoSpreeuw self-requested a review May 12, 2026 15:41
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this such a huge file?

Comment thread lib/sapporo_2/Makefile Outdated

.DEFAULT_GOAL := all

VERSION := eeac0835f80d6e0e8ca778bdea4dbf3ae799ca29
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERSION := 7cae51ed1368ea457fb5f3ca01b4775f7558a9e7

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add this.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done through commit 65164fa.

HannoSpreeuw
HannoSpreeuw previously approved these changes May 15, 2026
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Development Board May 15, 2026
The previous hash pointed to the Sapporo 2 repo before PR 16 "Add uninstall target to build system".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants