chore(ci): generate sigstore bundles instead of signatures and certs - #5092
chore(ci): generate sigstore bundles instead of signatures and certs#5092scop wants to merge 1 commit into
Conversation
Signed-off-by: Ville Skyttä <ville.skytta@iki.fi>
|
This needs more careful review on the impact of the install.sh verify feature also. I'll dig into this and report back what I find. |
Hey! I just wanted to pop in here as I only recently saw this issue while scrolling through, and actually touches upon what I commented in #585 (comment) This will indeed require changes for the install script, the bigger problem I suspect that due to immutable releases you will actually need to check what version it has, and if it’s a version that is post whenever this would be merged, to verify via bundle instead. Assuming that the intent would ofcourse be to actually deprecate the deprecated method. Because otherwise let’s say somebody tries to download vX.Y.Z which is before this, it would break because the install script in most cases(including sbom-action) is pulled from main(which has its own issues with interior mutability but I digress that’s for that repo). So what would be needed:
For the first, this is contained inside of lines 644-656, as not only the command for checking (verify-sign, 592-615) need to be changed, but also what files it would attempt to download would need to be changed. If it would help out I can see if I can have a POC as I’ve been working on areas similar to this attempting to implement my own syft-download action(Due to my dislike of interior mutability in the public aftion). Overall this would require a definitive design decision on how/if to handle the backwards compatibility. Currently as can be seen in the code it checks the version, aborting the install if attempting to install a version that doesn’t have co-sign signatures available. So I suppose expanding on this could be adding a vb or similar option, but that becomes a design choice. Abort if version less then Y, before which no co-sign signatures where given OR Abort if version less than Y I do apologize if this is the wrong place to place such information, I do not often interact in this sort of way, and hope the above can be atleast somewhat helpful from my time looking into this stuff recently. |
Description
Separate signatures and certificates are deprecated as of cosign 3.1.1,
refs https://github.com/sigstore/cosign/releases/tag/v3.1.1, https://github.com/sigstore/cosign/releases/tag/v3.1.2
Type of change
Checklist
Issue references