fix(invoices): preserve Lightning Address error messages instead of generic catch-all#147
Merged
andrerfneves merged 1 commit intoJun 12, 2026
Conversation
…eneric catch-all The handleLightningAddress catch block was swallowing all errors and returning 'This identifier does not support Lightning Address yet.' for every failure including network errors, CORS failures, JSON parse errors, and HTTP errors. This was misleading because users would see the same message regardless of whether the domain had no Lightning Address support or the service was simply temporarily unreachable. Changes: - Preserve the original error.message in the catch block - Fall back to 'Could not resolve Lightning Address.' when message is empty - Update test expectation to match actual error propagation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
andrerfneves
deleted the
maintenance/fix-lightning-address-error-20260605
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
handleLightningAddresscatch block was swallowing all errors and returning the same misleading message regardless of the actual failure cause.Problem
Changes
error.messagein the catch blockVerification
npm run buildcompletes successfully