Skip to content

test: neutralize third-party fixture names - #34

Merged
antoinevalentinHA merged 1 commit into
masterfrom
test/neutralize-third-party-fixture-names
Aug 21, 2026
Merged

test: neutralize third-party fixture names#34
antoinevalentinHA merged 1 commit into
masterfrom
test/neutralize-third-party-fixture-names

Conversation

@antoinevalentinHA

Copy link
Copy Markdown
Owner

Five fixture strings named third-party works. They were test data and nothing else.

  • Five replacements, in three test files: a pack path in the negative case of isConversionOutput, a metadata title, and a conversion record's source name.
  • No behaviour and no functional assertion changed. Where a value is asserted, the fixture and its expected value changed together, so each comparison holds exactly as before. Assertion counts are identical file by file (20/20, 41/41, 59/59), as are the test counts (8/8, 12/12, 25/25).
  • The .zip extension is kept where it is part of what the fixture represents. The fs case keeps its extensionless, space-bearing shape, which is what makes it a valid negative.
  • Test counts unchanged: 282 Java, 57 JavaScript.
  • No identified title left in the tracked repository: Lucky Luke, Lucky, Cornebidouille, Dans la classe, Daltons and Musique as a whole word all return zero.

No production code, no README, no TESTING.md. yarn.lock is untouched — the Luke it appears to contain is a substring of an integrity hash, not a title.

🤖 Generated with Claude Code

Five fixture strings named third-party works. They were test data and
nothing more: a pack path in the negative case of isConversionOutput, a
metadata title, and a conversion record's source name.

Each is now a neutral label, and where a value is asserted the fixture
and its expected value changed together, so every comparison holds as it
did. The .zip extension is kept where it is part of what the fixture
represents, as is the space-bearing, extensionless shape the fs case
relies on.

No production code, no assertion added or removed, no logic touched.
Test counts unchanged: 282 Java, 57 JavaScript.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@antoinevalentinHA
antoinevalentinHA merged commit b7cf2c6 into master Aug 21, 2026
3 checks passed
@antoinevalentinHA
antoinevalentinHA deleted the test/neutralize-third-party-fixture-names branch August 21, 2026 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant