test: neutralize third-party fixture names - #34
Merged
antoinevalentinHA merged 1 commit intoAug 21, 2026
Conversation
Five fixture strings named third-party works. They were test data and nothing more: a pack path in the negative case of isConversionOutput, a metadata title, and a conversion record's source name. Each is now a neutral label, and where a value is asserted the fixture and its expected value changed together, so every comparison holds as it did. The .zip extension is kept where it is part of what the fixture represents, as is the space-bearing, extensionless shape the fs case relies on. No production code, no assertion added or removed, no logic touched. Test counts unchanged: 282 Java, 57 JavaScript. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
antoinevalentinHA
deleted the
test/neutralize-third-party-fixture-names
branch
August 21, 2026 06:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five fixture strings named third-party works. They were test data and nothing else.
isConversionOutput, a metadata title, and a conversion record's source name..zipextension is kept where it is part of what the fixture represents. Thefscase keeps its extensionless, space-bearing shape, which is what makes it a valid negative.Lucky Luke,Lucky,Cornebidouille,Dans la classe,DaltonsandMusiqueas a whole word all return zero.No production code, no README, no
TESTING.md.yarn.lockis untouched — theLukeit appears to contain is a substring of an integrity hash, not a title.🤖 Generated with Claude Code