Removes direct access to COC segment marker.#312
Merged
Merged
Conversation
palemieux
suggested changes
Jul 1, 2026
| { | ||
| ojph::codestream codestream; | ||
| ojph::j2c_infile j2c_file; | ||
| j2c_file.open("mixed_rev_irrev_4comp.j2c"); |
Contributor
There was a problem hiding this comment.
This should be created in the build directory, so that it is not checked-in.
…ved an unneeded file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct access to the COC marker segment by the end user of the library proved to be problematic and perhaps confusing.
Here direct access is totally removed. It is now indirectly accessed through the param_cod object.
This commit borrows code and ideas from PRs #272 and #309.
@palemieux I integrated your #272 and #309 PRs. I updated the test code. Have a look and let me know if there are any concerns. I will merge it tomorrow morning if there are none. Cheers, Aous