Fix "MapStates replays stale sub-state on repeated invocations when parent has a cascading state_initializer"#762
Open
hippalectryon-0 wants to merge 1 commit into
Open
Conversation
skrawcz
requested changes
May 9, 2026
Contributor
skrawcz
left a comment
There was a problem hiding this comment.
Good catch and clean fix! The root cause analysis in #761 is thorough and the fix is correct — including sequence_id in the sub-app key ensures repeated invocations with initialize_from get distinct sub-application IDs.
Backwards compatibility is fine here: if old persisted sub-app state exists, initialize_from simply falls back to default_state and the sub-apps run fresh, which is correct.
One ask before merge: please add a regression test in tests/core/test_parallelism.py. The MWE in #761 is a great template — something like:
- Create a
MapStatesaction with cascade persistence (initialize_fromon the parent) - Run the parent app through the MapStates action twice (two steps)
- Assert the second invocation produces fresh results, not a replay of the first
Without an automated test, a future refactor could easily reintroduce this.
09b45ac to
a0cd351
Compare
Author
|
I checked that the test passes with this PR and fails with the main branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #761
Changes
Added sequence ID in the tasks keys
How I tested this
Tested against the MWE of the issue
Checklist