Conversation
In OTP 29 catch statements started to throw deprecation warnings, and since we're using `warnings_as_errors` our compilation fails. The catch construct hasn't been scheduled for removal yet [1] so for now just to compile ibrowse add a per-module compiler directive. This allows catch rewrites to be done incrementally module-by-module eventually. This is an intermediate alternative for cmullaparthi/ibrowse#187 for now. [1] https://www.erlang.org/doc/scheduled_for_removal.html
When vendoring this dependency it may not be called `ibrowse` when checked out (as is in the case of CouchDB, where it's called couchdb-ibrowse). Then the CI would break because `../../ibrowse/ebin` wouldn't exist. To make it work as any directory name just use a single `../` path and when including in test use `../`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In OTP 29 catch statements started to throw deprecation warnings, and since we're using
warnings_as_errorsour compilation fails. The catch construct hasn't been scheduled for removal yet [1] so for now just to compile ibrowse add a per-module compiler directive. This allows catch rewrites to be done incrementally module-by-module eventually.This is an intermediate alternative for
cmullaparthi/ibrowse#187 for now.
[1] https://www.erlang.org/doc/scheduled_for_removal.html