[FLINK-AGENTS][api] Fix Kryo deserialization failure for Event classes with immutable lists#677
Open
avichaym wants to merge 1 commit into
Open
Conversation
…s with immutable lists Wrap List arguments in new ArrayList<>() in event constructors so callers can safely pass List.of(...), Arrays.asList(...), or any immutable list without hitting a JDK 17+ Kryo InaccessibleObjectException at runtime. Affected events: ChatRequestEvent (messages), ContextRetrievalResponseEvent (documents), ToolRequestEvent (tool_calls). The defensive copy is applied before setAttr() so the stored list is always a plain mutable ArrayList that Kryo can serialize without reflective access to sealed JDK internal classes.
github-actions
Bot
added
doc-label-missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #673
Wraps list arguments in new ArrayList<>() before passing to setAttr() in ChatRequestEvent, ContextRetrievalResponseEvent, and ToolRequestEvent. Without this, passing List.of(...) crashes Kryo on JDK 17+ with InaccessibleObjectException.