[FLINK-38489][table] Avoid unnecessary DELETE inference for ChangelogNormalize - #28890
Open
Au-Miner wants to merge 1 commit into
Open
[FLINK-38489][table] Avoid unnecessary DELETE inference for ChangelogNormalize#28890Au-Miner wants to merge 1 commit into
Au-Miner wants to merge 1 commit into
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Improve the changelog mode inference for
ChangelogNormalizeby excludingDELETEwhen the operator has no filter and its input cannot produce deletions. This prevents an overly broad changelog mode from blocking planner optimizations such as delta join conversion.Brief change log
FlinkChangelogModeInferenceProgram.SatisfyModifyKindSetTraitVisitorto infer onlyINSERTandUPDATEmodify kinds for aStreamPhysicalChangelogNormalizewithout a filter when its input does not containDELETE.DELETEor a filter can turn an update into a deletion.Verifying this change
Added
ChangelogModeInferenceTestcases verifying that:ChangelogNormalizewithout a filter and without input deletions produces[I, UB, UA].ChangelogNormalizewith a filter still produces[I, UB, UA, D].Updated
TableScanTestandDeltaJoinTestexpected plans to verify that the refined mode removes unnecessaryChangelogNormalizenodes and enables delta-join conversion forI, UAinputs.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation