Skip to content

[FLINK-40322][python] Fix Array/Multiset from_sql_type to decode elements #28912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikolauspschuetz wants to merge 2 commits into
base: master
Choose a base branch
from
+14 −2
Open

[FLINK-40322][python] Fix Array/Multiset from_sql_type to decode elements #28912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d35cf6e
[FLINK-40322][python] Add failing tests for Array/Multiset from_sql_type
nikolauspschuetz Aug 4, 2026
e72257f
[FLINK-40322][python] Fix Array/Multiset from_sql_type to decode elem…
nikolauspschuetz Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions flink-python/pyflink/table/tests/test_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,18 @@ def test_datetype_equal_zero(self):
dt = DataTypes.DATE()
self.assertEqual(dt.from_sql_type(0), datetime.date(1970, 1, 1))

def test_array_from_sql_type_converts_elements(self):
at = DataTypes.ARRAY(DataTypes.DATE())
self.assertEqual(
at.from_sql_type([0, 1]),
[datetime.date(1970, 1, 1), datetime.date(1970, 1, 2)])

def test_multiset_from_sql_type_converts_elements(self):
mst = DataTypes.MULTISET(DataTypes.DATE())
self.assertEqual(
mst.from_sql_type([0, 1]),
[datetime.date(1970, 1, 1), datetime.date(1970, 1, 2)])

@unittest.skipIf(on_windows(), "Windows x64 system only support the datetime not larger "
"than time.ctime(32536799999), so this test can't run "
"under Windows platform")
Expand Down
4 changes: 2 additions & 2 deletions flink-python/pyflink/table/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,7 +931,7 @@ def to_sql_type(self, obj):
def from_sql_type(self, obj):
if not self.need_conversion():
return obj
return obj and [self.element_type.to_sql_type(v) for v in obj]
return obj and [self.element_type.from_sql_type(v) for v in obj]


class ListViewType(DataType):
Expand Down Expand Up @@ -1059,7 +1059,7 @@ def to_sql_type(self, obj):
def from_sql_type(self, obj):
if not self.need_conversion():
return obj
return obj and [self.element_type.to_sql_type(v) for v in obj]
return obj and [self.element_type.from_sql_type(v) for v in obj]


class RowField(object):
Expand Down