Skip to content

[FLINK-40208][runtime] Add test coverage and blank-key validation for JobMdcRegistry - #28917

Open
Izeren wants to merge 1 commit into
apache:masterfrom
Izeren:FLINK-40208/test-coverage-followup
Open

[FLINK-40208][runtime] Add test coverage and blank-key validation for JobMdcRegistry#28917
Izeren wants to merge 1 commit into
apache:masterfrom
Izeren:FLINK-40208/test-coverage-followup

Conversation

@Izeren

@Izeren Izeren commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

What is the purpose of the change

This is a follow-up to FLINK-40208, which introduced JobMdcRegistry for config-driven MDC enrichment in Flink jobs. This PR adds missing test coverage for three execution paths not exercised by the base PR, and adds a blank-key guard to MdcUtils.

Brief change log

  • Added a couple of tests reported on original PR.
  • Resolved doc priority conflict.
  • Added check for blank keys in configuration with warning.

Verifying this change

  • Unit tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no (test coverage and defensive guard for FLINK-40208)
  • If yes, how is the feature documented? not applicable

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: Claude Code (claude-sonnet-4-6)

@Izeren
Izeren marked this pull request as ready for review August 4, 2026 09:32
@Izeren

Izeren commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

@rkhachatryan, I have added more tests and minor improvements as a follow-up, PTAL when you have time.
This is based on feedback from @wenshao

@flinkbot

flinkbot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants