fix(dart): added <<< for correct logical right shift semantics in uint#3607
Open
ayush00git wants to merge 2 commits intoapache:mainfrom
Open
fix(dart): added <<< for correct logical right shift semantics in uint#3607ayush00git wants to merge 2 commits intoapache:mainfrom
ayush00git wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@chaokunyang |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The unsigned integer wrapper classes in Fory's Dart implementation (specifically
Uint64) implement the right shift>>operator by delegating directly to Dart's nativeint.operator >>. In Dart,>>performs an arithmetic (sign-extending) right shift.What does this PR do?
Implement the operator >>> (logical right shift) for all unsigned integer wrappers to expose a proper logical shift API.
Related issues
#3606
AI Contribution Checklist
yes/noyes, I included a completed AI Contribution Checklist in this PR description and the requiredAI Usage Disclosure.yes, my PR description includes the requiredai_reviewsummary and screenshot evidence of the final clean AI review results from both fresh reviewers on the current PR diff or current HEAD after the latest code changes.Does this PR introduce any user-facing change?
Benchmark