perf(dart): typed-container write fast path with scan elimination#3609
Merged
chaokunyang merged 2 commits intoapache:mainfrom Apr 23, 2026
Merged
perf(dart): typed-container write fast path with scan elimination#3609chaokunyang merged 2 commits intoapache:mainfrom
chaokunyang merged 2 commits intoapache:mainfrom
Conversation
Collaborator
|
@yash-agarwa-l Could you merge main branch, I've refactored fory dart to support dart web |
Contributor
Author
I will do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Writing
List<T>/Set<T>struct fields paid an O(n) scan to detect heterogeneous types and nulls. Codegen already knows the element type is concrete and non-nullable — the scan is pure overhead.What does this PR do?
writeTypedListPayload<T>/writeTypedSetPayload<T>that resolveTypeInfoonce and write the header/type-meta without scanning.writeGeneratedDirectListValue<T>/writeGeneratedDirectSetValue<T>generated-code entry points.DartTypenullability) that emits the fast path for non-nullable, non-ref, non-dynamic list/set fields; everything else keeps the existing slow path.Related issues
#3558
AI Contribution Checklist
yes/noyes, I included a completed AI Contribution Checklist in this PR description and the requiredAI Usage Disclosure.yes, my PR description includes the requiredai_reviewsummary and screenshot evidence of the final clean AI review results from both fresh reviewers on the current PR diff or current HEAD after the latest code changes.Does this PR introduce any user-facing change?
No user-facing or wire-format change. Serialized bytes are byte-identical to main.
Benchmark