GUACAMOLE-808: Add page redirection on login - #1233
Open
adb014 wants to merge 2 commits into
Open
Conversation
- Allow store the full URI in RequestDetails
- Add methods to get/set originalURI in AuthenticatedUser and derived classes
- Set the originalURI in JDBC base class
- Promote session manager to base SSO class; Use it to store the originalURI in openid
- Allow redirection to be stored in GuacamoleSession iff new login
- Store the redirection in the GuacamoleSession the AuthenticationService
- If redirection set in GuacamoleSession pass it back on the /api/tokens REST endpoint
- In the javascript in the redirection is set on the /api/tokens endpoint, redirect after authentication
necouchman
requested changes
Aug 6, 2026
| $location.url('/'); | ||
| else | ||
| $route.reload(); | ||
| $route.reload(); |
Contributor
There was a problem hiding this comment.
Is this change going to adversely impact situations where SSO is not in use and where the behavior of the redirection back to the home screen actually would be expected? For example, configurations where JDBC is the only provider in use, and the re-authentication gets triggered?
Author
There was a problem hiding this comment.
Why would you expect the behavior to be different with or without SSO ? OpenID SSO needs special treatment because of the redirection to the identity provider... Some SSO providers, like the SSL provider don't use redirection and so the base treatment is used... In all cases the idea is to come back to the requested page after authentication
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is quite an intrusive pull request that allows reauthentication to redirect back to the initial page so that in progress work can be directly refound.. See the discussion in the Jira for details