GUACAMOLE-2313: Disambiguate handling of lock modifiers and Mac-specific keys. - #700
Merged
Merged
Conversation
mike-jumper
force-pushed
the
mac-specific-keys
branch
from
August 5, 2026 19:00
980f7f9 to
f34c3aa
Compare
necouchman
approved these changes
Aug 5, 2026
necouchman
left a comment
necouchman
left a comment
Contributor
There was a problem hiding this comment.
Good with the changes, but feel like we need to address the build issue before merging (GUACAMOLE-2315).
Contributor
Author
Yep, I agree. |
…eneral VNC keysym conventions.
mike-jumper
force-pushed
the
mac-specific-keys
branch
from
August 6, 2026 07:19
f34c3aa to
4bdca4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is the server half of the changes proposed by apache/guacamole-client#1238, adding handling for the Command/Option keysyms and ensuring keypresses of modifiers and locks do not cause the terminal to suddenly scroll down.