Skip to content

Detect Source Table Format#830

Open
sapienza88 wants to merge 24 commits into
apache:mainfrom
sapienza88:detect_source_table
Open

Detect Source Table Format#830
sapienza88 wants to merge 24 commits into
apache:mainfrom
sapienza88:detect_source_table

Conversation

@sapienza88

Copy link
Copy Markdown
Contributor

Important Read

  • Please ensure the GitHub issue is mentioned at the beginning of the PR

What is the purpose of the pull request

(For example: This pull request implements the sync for delta format.)

Brief change log

(for example:)

  • Fixed JSON parsing error when persisting state
  • Added unit tests for schema evolution

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added TestConversionController to verify the change.
  • Manually verified the change by running a job locally.

@sapienza88 sapienza88 changed the title Detect source table type instead of setting it manually in the config Detect Source Table Format Jun 18, 2026

@vinishjail97 vinishjail97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For iceberg tables, the metadata can be in a different path and can't be detected by doing a prefix check? @sapienza88 Any idea where this change will be useful?

Comment thread xtable-api/src/main/java/org/apache/xtable/conversion/DetectSourceType.java Outdated
Comment thread xtable-api/src/main/java/org/apache/xtable/conversion/DetectSourceType.java Outdated
Comment thread xtable-api/src/main/java/org/apache/xtable/conversion/DetectSourceType.java Outdated
Comment thread xtable-api/src/main/java/org/apache/xtable/conversion/DetectSourceType.java Outdated
Comment thread xtable-api/src/main/java/org/apache/xtable/conversion/DetectSourceType.java Outdated
@sapienza88

Copy link
Copy Markdown
Contributor Author

For iceberg tables, the metadata can be in a different path and can't be detected by doing a prefix check? @sapienza88 Any idea where this change will be useful?

True, I fixed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants