Skip to content

fix(skills): derive the two remaining Airflow literals from project config #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dpol1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(skills): derive the two remaining Airflow literals from project config #1144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions skills/pr-management-stats/fetch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,8 @@ Two stages:
2. **Fetch comments in aliased batches** of **30 PRs per GraphQL call**. Each alias queries one PR with `comments(last: 25) { nodes { author { login } authorAssociation createdAt body } }`. A single query with 30 aliases stays well inside GitHub's complexity budget; larger batch sizes occasionally hit `MAX_NODE_LIMIT_EXCEEDED`. Budget: ~54 GraphQL calls for 1600 PRs; end-to-end around 60 seconds on a warm token.

```graphql
query {
repository(owner:"apache",name:"airflow") {
query($owner: String!, $repo: String!) { # bound from <upstream> split on "/"
repository(owner:$owner, name:$repo) {
pr63407: pullRequest(number:63407) {
number author{login} authorAssociation closedAt mergedAt state merged
labels(first:30){nodes{name}}
Expand Down
2 changes: 1 addition & 1 deletion skills/release-announce-draft/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ before including it.

- Download links in the site files must resolve through the `closer.lua`
mirror redirector (e.g.
`https://www.apache.org/dyn/closer.lua?path=airflow/<version>/...`),
`https://www.apache.org/dyn/closer.lua?path=<project>/<version>/...`),
not through a direct `dist.apache.org` URL.
- The PR is opened (not merged) by this skill; a committer merges it
after the `[ANNOUNCE]` email is sent.
Expand Down
5 changes: 5 additions & 0 deletions tools/dev/check-placeholders.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,11 @@ FORBIDDEN_PATTERNS=(
"airflow-s/airflow-s"
"Apache Airflow"
"apache.org/airflow"
# Lowercase forms that slip past the four above: a GraphQL
# `repository(owner:"apache",name:"airflow")` argument and a
# `closer.lua?path=airflow/` dist path.
'name:"airflow"'
"path=airflow"
)

# Files / directories where Airflow references are intentional:
Expand Down