fix(qdp): apply shared max qubit validation#1442
Merged
Merged
Conversation
Signed-off-by: viiccwen <vicwen@apache.org>
ryankert01
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #1262
Changes
Why
Several amplitude f32 batch and GPU-pointer paths calculated
1 << num_qubitswithout first using QDP's sharedvalidate_qubit_countfunction. Excessive inputs could therefore panic on shift overflow or proceed toward an impractical allocation instead of returning the establishedMahoutError::InvalidInput. QDP also retained an unused duplicateMAX_QUBITSmacro in the CUDA kernel configuration.How
validate_qubit_countbefore state-length calculations in the uncovered float32 batch and float32/float64 GPU-pointer single and batch paths.MAX_QUBITSconstant as the single effective validation policy.MAX_QUBITSdefinition and update the stale Rust comment.Runtime device-capacity planning remains outside this cleanup's scope.
Checklist