feat(cli): expose ACP session configuration - #4051
Draft
Sun-GLiang wants to merge 11 commits into
Draft
Conversation
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
Generated-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configOptionsfrom the Runtime Host's committed Session projection for every successfulsession/new: permission mode, thinking level, collaboration mode, and orchestration mode.session/set_config_optionthrough the official SDK route for Sessions owned by the current ACP connection, with validation before Host I/O and stable ACP error envelopes.SessionConfigurationCAS update that preserves model selection and unrelated fields, re-reading after revision conflicts for at most three attempts.session/set_modeunsupported and unadvertised. ACPsession/newhas no configuration/mode input, so this PR does not represent create-timeSessionStartModeor pretend it is mutable.Refs #3132
Depends on #3744
Review dependency
mainafter feat(cli): add ACP session creation and listing #3744 merges so this PR contains only the PR3 delta.4ed9973d6. Because the dependency branch lives in a fork, GitHub cannot use it as the base branch of anapache/makaPR; until feat(cli): add ACP session creation and listing #3744 merges, the displayed diff also includes PR2.4ed9973d6..0bca0ed01.Verification
TMPDIR=/private/tmp npm --workspace maka-agent test— 537 passed, 0 failed.npm run typechecknpm run lintnpm run format:checkgit diff 4ed9973d68715d9441f6ab843824fb4897a42a3e..HEAD --checkAI use
Select exactly one:
Tool(s) and scope: Codex assisted with design, implementation, tests, verification, checklist alignment, and review. Every PR3 commit includes a
Generated-by: Codextrailer.Checklist
Does this PR entail a change in behavior?