Skip to content

dev(runtime-host): build target-aware host packages - #4087

Merged
M4n5ter merged 1 commit into
mainfrom
feat/runtime-host-target-aware-dev-package
Aug 28, 2026
Merged

dev(runtime-host): build target-aware host packages#4087
M4n5ter merged 1 commit into
mainfrom
feat/runtime-host-target-aware-dev-package

Conversation

@M4n5ter

@M4n5ter M4n5ter commented Aug 28, 2026

Copy link
Copy Markdown
Member

Summary

Development Desktop setup now resolves Runtime Host packages against the target environment instead of the Desktop process platform.

  • make the development package target an explicit, typed resolver input and cache archives per target
  • probe SSH host OS/architecture before development setup or update
  • keep WSL framed-stdio packages peer-less, so Windows-to-WSL development does not require Rust, Zig, or a host-native addon
  • build supported Linux cross-target addons with cargo-zigbuild, with actionable prerequisite and unsupported-target failures
  • leave published release packaging unchanged

Fixes #4085

中文说明

开发版 Desktop setup 现在按目标环境解析 Runtime Host package,不再错误地使用 Desktop 进程所在平台。

  • 将开发 package target 变成显式、类型安全的 resolver 输入,并按 target 缓存 archive
  • 在开发版 SSH setup/update 前探测目标 OS/架构
  • WSL framed-stdio 使用不含 direct-peer addon 的 package,因此 Windows 到 WSL 的开发流程不要求 Rust、Zig 或宿主机 native addon
  • 支持的 Linux 跨目标 addon 使用 cargo-zigbuild;缺少依赖或目标不支持时尽早给出可操作错误
  • 正式发布的打包行为保持不变

关闭 #4085

Verification

  • npm run lint
  • npm run format:check
  • npm run typecheck
  • mise x node@24.18.1 -- npm run check:release — 110 passed
  • affected compiled Desktop suites — 40 passed
  • built a real none development archive and verified it contains no direct-peer prebuild
  • built a real linux-arm64 archive from Linux x64 and verified its addon is an AArch64 ELF
  • Windows Electron → fresh Maka-Test WSL setup, project selection, and real session completed with WSL_TARGET_PACKAGE_OK; the generated WSL archive contained no direct-peer prebuild and no Cargo/Zig process ran
中文验证说明
  • lint、format、typecheck 均通过
  • release check 110 项通过,受影响 Desktop suite 40 项通过
  • 实际构建并检查了 peer-less WSL archive 与 Linux x64 → arm64 跨目标 archive
  • 在 Windows Electron 中重新安装并连接 Maka-Test WSL,成功选择项目并完成真实 session;WSL archive 不含 direct-peer prebuild,且未启动 Cargo/Zig

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Codex implemented the target-aware resolver, SSH target preflight, packaging changes, focused tests, and cross-platform verification.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

@M4n5ter M4n5ter self-assigned this Aug 28, 2026
@github-actions github-actions Bot added the effort/M Under 500 readable lines label Aug 28, 2026

@jackwener jackwener left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed exact head 32316a4ed6b5627846d469b22f8d4adbbf443daf and found no blocking issue.

Development package selection now follows the target environment instead of the Desktop process, with build/cache ownership separated by target. WSL deliberately selects the peer-less archive; development SSH performs a bounded target probe before resolving its archive; supported cross-target peer builds are explicit and fail early when prerequisites or targets are unsupported. Published release packaging remains on its existing all-target path. The current-main synthetic merge is clean, and the exact-head test and quality checks are green; the separate package workflow was still running when I submitted this review.


Posted by an automated review agent operated by @WAWQAQ. This is not an
independent human review and does not satisfy the committer review required by
CONTRIBUTING.md. A human is accountable for this comment — please push back if
anything here is wrong.

简体中文

本条评论由 @WAWQAQ 运行的自动化审查程序发出。它不构成 CONTRIBUTING.md
所要求的独立人类审查,也不能替代人类审查。有人类对本条评论负责,如有错误请直接指出。

@M4n5ter
M4n5ter merged commit cb60d41 into main Aug 28, 2026
15 checks passed
@M4n5ter
M4n5ter deleted the feat/runtime-host-target-aware-dev-package branch August 28, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/M Under 500 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dev(runtime-host): build target-aware archives for cross-platform hosts

2 participants